Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-server): make it easier to run multiple plugin-server instances locally #17456

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

bretthoerner
Copy link
Contributor

@bretthoerner bretthoerner commented Sep 14, 2023

Problem

It was first impossible (port collision) and second annoying (autoreload) to run 2 plugin-servers locally. This is useful for trying out things like incompatible Kafka consumer group protocols.

Changes

Add the ability to customize the status/metric port and whether or not to use nodemon (it's annoying to autorestart a process on changes when the goal is to leave a pre-existing process up in the group).

How did you test this code?

Used it locally, it's just dev stuff.

@bretthoerner bretthoerner requested a review from a team September 14, 2023 20:06
Copy link
Contributor

@tomasfarias tomasfarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bretthoerner bretthoerner merged commit 5b5d0d4 into master Sep 15, 2023
61 checks passed
@bretthoerner bretthoerner deleted the brett/rdkafka-health branch September 15, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants