fix: Fix high memory usage in send_usage_reports #17447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
changed the title
|
The was it's written currently is used for tests so I'm going to do some reorganization and cleanup here to make it work for tests and more readable in general. |
|
Ha I took your 3-line pr and 10x'd it. It's mostly reorganizing code and fixing up tests to cope with not keeping all the reports around in memory. If you can give it a quick once-over then we can call it mutually-approved @frankh |
daibhin
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Fix high memory usage in send_usage_reports * do a lot of reorg * fix tests * fix mypy --------- Co-authored-by: Raquel Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As we are sending usage reports we store them all in an
all_reportsvariable. We don't use this variable at all except if it's a dry run, and to printlen(reports)at the end.Keep this behaviour for dry runs only
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?