fix(experiments): JS snippet typo #17434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lior539
requested review from
neilkakkar,
tiina303,
pauldambra and
benjackwhite
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
changed the title
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
pauldambra
pushed a commit
that referenced
this pull request
Sep 14, 2023
daibhin
added a commit
that referenced
this pull request
Sep 14, 2023
pauldambra
added a commit
that referenced
this pull request
Sep 14, 2023
* fix: universal search with notebooks disabled * Update frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx Co-authored-by: Paul D'Ambra <[email protected]> * Update UI snapshots for `chromium` (1) * fix(experiments): JS snippet typo (#17434) * chore: clear the console in storybook a little (#17430) * chore: clear the console in storybook a little * Update .storybook/preview.tsx * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * maybe this? * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * maybe this * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Paul D'Ambra <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Small typo for on experiments page JS code to override feature flags. Snippet used snake_case instead of camelCase
Reported by user here -> https://posthogusers.slack.com/archives/CTLTM70RM/p1694643924884199
How did you test this code?
👀