feat: Blacklisting webhooks #17421
Merged
feat: Blacklisting webhooks #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
approved these changes
Sep 13, 2023
frontend/src/lib/constants.tsx
Outdated
| @@ -166,6 +166,7 @@ export const FEATURE_FLAGS = { | |||
| // owner: #team-monitoring | |||
| SESSION_RECORDING_ALLOW_V1_SNAPSHOTS: 'session-recording-allow-v1-snapshots', | |||
| HOGQL_INSIGHTS: 'hogql-insights', // owner: @mariusandra | |||
| WEBHOOKS_BLACKLISTED: 'webhooks-blacklisted', // owner: @team-pipeline | |||
There was a problem hiding this comment.
I think it makes sense calling this a denylist
bretthoerner
approved these changes
Sep 13, 2023
|
|
||
| useEffect(() => { | ||
| if (currentTeam?.slack_incoming_webhook) { | ||
| setWebhook(currentTeam?.slack_incoming_webhook) | ||
| } | ||
| }, [currentTeam]) | ||
|
|
||
| const webhooks_blacklisted = featureFlags[FEATURE_FLAGS.WEBHOOKS_DENYLIST] | ||
| if (webhooks_blacklisted) { |
There was a problem hiding this comment.
related nit: probably good to align the variable name with the feature flag (or just if (featureFlags[FEATURE_FLAGS.WEBHOOKS_DENYLIST])
There was a problem hiding this comment.
merged cause I didn't want to wait for tests again 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've disabled a webhook for the same team twice due to it being really slow and contacted them about it. This will allow us to disable webhooks for the team until they talk to us.
context: https://posthog.slack.com/archives/C0185UNBSJZ/p1694611747313189?thread_ts=1694610989.528059&cid=C0185UNBSJZ
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
ran locally looked at the page first, enabled the feature flag, then it looked like this:
