Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use passed in setQuery value to update insight viz node #17417

Closed
wants to merge 1 commit into from
Closed

feat: use passed in setQuery value to update insight viz node #17417

wants to merge 1 commit into from

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 13, 2023 •
edited
Loading

Problem

There is no way to call setQuery in the insight viz node right now

Changes

Add it as part of the props to the InsightLogicProps and call it instead of the internal setQuery method

How did you test this code?

None, because yolo to see if this is the right approach

@PostHog PostHog deleted a comment from posthog-bot Sep 13, 2023
@daibhin
Copy link
Contributor Author

daibhin commented Sep 14, 2023

Closing in favour of #17442

@daibhin daibhin closed this Sep 14, 2023
@daibhin daibhin deleted the dn/updating-queries branch September 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daibhin