Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added button in playlist player to add the Replay below #17411

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

benjackwhite
Copy link
Contributor

Problem

Notebooks sort of replaces playlists so when you are looking at a playlist recording within a notebook it should show a button to pull out the recording below.

Changes

  • As it says
  • TODO: Follow up PR will make improvements overall to the playlist UI which will then navigate back to the list and also scroll to the added replay
    2023-09-13 10 00 55

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite merged commit e2a3bcf into master Sep 13, 2023
@benjackwhite benjackwhite deleted the fix/recording-pin-button branch September 13, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants