Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reporting of recording viewed #17410

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix: Reporting of recording viewed #17410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b99d4fa
Move code to report regardless of load path
benjackwhite Sep 13, 2023
5a720b9
Update UI snapshots for `chromium` (2)
github-actions[bot] Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...napshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 4 additions & 6 deletions frontend/src/scenes/session-recordings/player/sessionRecordingDataLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,6 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([

if (nextSourceToLoad) {
actions.loadRecordingSnapshotsV2(nextSourceToLoad)
} else {
actions.reportUsageIfFullyLoaded()
}
},
loadRecordingSnapshotsV1Success: ({ sessionPlayerSnapshotData }) => {
Expand All @@ -254,8 +252,6 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([

if (values.sessionPlayerSnapshotData?.next) {
actions.loadRecordingSnapshotsV1(values.sessionPlayerSnapshotData?.next)
} else {
actions.reportUsageIfFullyLoaded()
}
if (values.chunkPaginationIndex === 1 || values.loadedFromBlobStorage) {
// Not always accurate that recording is playable after first chunk is loaded, but good guesstimate for now
Expand All @@ -265,10 +261,12 @@ export const sessionRecordingDataLogic = kea<sessionRecordingDataLogicType>([
size: (values.sessionPlayerSnapshotData?.snapshots ?? []).length,
duration: Math.round(performance.now() - cache.snapshotsStartTime),
}

actions.reportViewed()
}
},
loadRecordingSnapshotsSuccess: () => {
actions.reportViewed()
actions.reportUsageIfFullyLoaded()
},
loadRecordingSnapshotsV1Failure: () => {
actions.loadRecordingSnapshotsFailure()
},
Expand Down