Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notebooks to universal search #17398

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 12, 2023

Problem

Notebooks do not appear in any universal search right now

Changes

Adds notebooks to universal search.

  • Only real big change here is moving the search key from s to search because that is what the universal search is setup to rely on by default

How did you test this code?

By 👁️
search

@daibhin daibhin requested a review from a team September 12, 2023 14:38
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

posthog/api/notebook.py Show resolved Hide resolved
@benjackwhite
Copy link
Contributor

Next step - Notebooks embedded within Notebooks? 🤔

@daibhin daibhin mentioned this pull request Sep 12, 2023
83 tasks
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to merge this and then wondered.... does this respect

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin daibhin merged commit ab0e989 into master Sep 13, 2023
24 checks passed
@daibhin daibhin deleted the dn-feat/notebooks-universal-search branch September 13, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants