-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add session_replay_events to lag monitoring #17397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - only thing I'm not sure about is how the count works. The replay_events is an aggregating merge tree and might not fit the format expected?
posthog/celery.py
Outdated
@@ -348,7 +348,7 @@ def pg_row_count(): | |||
pass | |||
|
|||
|
|||
CLICKHOUSE_TABLES = ["events", "person", "person_distinct_id2", "session_recording_events"] | |||
CLICKHOUSE_TABLES = ["events", "person", "person_distinct_id2", "session_recording_events", "session_replay_events"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, because we're hipsters session_replay_events
doesn't have an _timestamp
column 😊
Without a If we can add |
requires #16994 so that we have |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Problem
no visibility into lag on
session_replay_events
Changes
scrape it for visability
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?