Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add session_replay_events to lag monitoring #17397

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

fuziontech
Copy link
Member

Problem

no visibility into lag on session_replay_events

Changes

scrape it for visability

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only thing I'm not sure about is how the count works. The replay_events is an aggregating merge tree and might not fit the format expected?

@@ -348,7 +348,7 @@ def pg_row_count():
pass


CLICKHOUSE_TABLES = ["events", "person", "person_distinct_id2", "session_recording_events"]
CLICKHOUSE_TABLES = ["events", "person", "person_distinct_id2", "session_recording_events", "session_replay_events"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, because we're hipsters session_replay_events doesn't have an _timestamp column 😊

@fuziontech
Copy link
Member Author

Without a _timestamp field we can't track lag. If you try to use max_last_timestamp you currently get December 31, 2299, 11:43 PM which is not at all helpful for lag lol. We see into the future! 👀

If we can add _timestamp digested into a SimpleAggregateFunction(max, DateTime64(6, 'UTC')) field that would work for this though

@pauldambra
Copy link
Member

requires #16994 so that we have _timestamp to track

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@pauldambra pauldambra merged commit b52f8cb into master Sep 28, 2023
66 checks passed
@pauldambra pauldambra deleted the session_replay_alerting branch September 28, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants