chore: refactor webhooks groupIntoBatches #17395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiina303
force-pushed
the
webhooks-group-into-batches-general
branch
from
8485263 to
fe55576
Compare
xvello
approved these changes
Sep 12, 2023
Comment on lines
72
to
74
| const batchesWithOffsets = groupIntoBatchesByUsage(batch.messages, concurrency, (teamId) => | ||
| actionMatcher.hasWebhooks(teamId) | ||
| ) |
There was a problem hiding this comment.
nit: you might be able to get away with passing the function ref itself? Would need to confirm it compiles fine
Suggested change
| const batchesWithOffsets = groupIntoBatchesByUsage(batch.messages, concurrency, (teamId) => | |
| actionMatcher.hasWebhooks(teamId) | |
| ) | |
| const batchesWithOffsets = groupIntoBatchesByUsage(batch.messages, concurrency, actionMatcher.hasWebhooks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Not sure why we get test failures in #17186 so this is part 1 of it
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?