feat: search more than only the notebook title #17379
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
frontend/src/scenes/notebooks/Nodes/NotebookNodeReplayTimestamp.tsx
Outdated
Show resolved
Hide resolved
| @@ -75,6 +75,25 @@ export const NotebookNodeReplayTimestamp = Node.create({ | |||
| group: 'inline', | |||
| atom: true, | |||
|
|
|||
| serializedText: | |||
| () => | |||
| (attrs: { playbackTime: number }): string => { | |||
There was a problem hiding this comment.
Do the types not get carried over here?
There was a problem hiding this comment.
I missed that there was already an interface, so can use that... but (I think) there's no type detection here because we're not wrapped in the create widget function that carries the type
Co-authored-by: David Newell <[email protected]>
Co-authored-by: David Newell <[email protected]>
Co-authored-by: David Newell <[email protected]>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| @@ -79,6 +79,10 @@ export const NotebookNodeImage = createPostHogWidgetNode<NotebookNodeImageAttrib | |||
| nodeType: NotebookNodeType.Image, | |||
| title: 'Image', | |||
| Component, | |||
| serializedText: (attrs) => { | |||
| // TODO file is null when this runs... should it be? | |||
There was a problem hiding this comment.
I think the right thing to do here might be to set the title to be the name of the file when updateAttributes is called after uploading the file, and then the serialized text could just be attrs.title. That's for a follow up though
Extends notebook search to cover all text content in the notebook
## TODO