Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quotes in Go feature flag snippit #17363

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: quotes in Go feature flag snippit #17363

merged 2 commits into from
Oct 4, 2023

Conversation

craigpastro
Copy link
Contributor

@craigpastro craigpastro commented Sep 8, 2023

Problem

The Go snippet for feature flags is not quoted correctly. See the screenshot. The quotes around v2_enabled should be " and not '. This PR fixes the quoting (I think).

I actually filed a ticket for this yesterday because I didn't think this was something I couldn't fix. However, I could! (I think.) The ticket number is 5651.

Screenshot 2023-09-07 at 10 09 33 AM

Changes

Change single quotes to double quotes in the Go code snippet.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

I didn't.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@craigpastro
Copy link
Contributor Author

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Commenting to keep it open. It needs a review.

@timgl timgl enabled auto-merge (squash) September 25, 2023 15:19
@timgl
Copy link
Collaborator

timgl commented Sep 25, 2023

Sorry for the late response Craig, and thanks for the PR 🙏

@craigpastro
Copy link
Contributor Author

Thanks for the review, Tim!

@posthog-bot posthog-bot removed the stale label Sep 26, 2023
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Twixes Twixes disabled auto-merge October 4, 2023 08:29
@Twixes Twixes merged commit 339e8ac into PostHog:master Oct 4, 2023
65 checks passed
@craigpastro craigpastro deleted the fix-quote-in-go-ff-snippit branch October 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants