Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add another illegal id #17325

Merged
merged 9 commits into from
Sep 12, 2023
Merged

fix: add another illegal id #17325

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddbaf81
fix: add another illegal id
pauldambra Sep 5, 2023
1b00490
and more
pauldambra Sep 5, 2023
bb1c308
test all the cases and simplify a little
pauldambra Sep 5, 2023
6b2b9e1
to lowercase
pauldambra Sep 5, 2023
8ef37cb
Merge branch 'master' into fix/add-illegal-id
pauldambra Sep 11, 2023
c5d71d0
fewer more concrete tests
pauldambra Sep 11, 2023
8204ca4
test a theory
pauldambra Sep 11, 2023
8a04acc
Revert "test a theory"
pauldambra Sep 11, 2023
6f166f7
historically we wanted to allow Nan but not NaN :shrug:
pauldambra Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion plugin-server/src/worker/ingestion/person-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,18 @@ export const mergeFinalFailuresCounter = new Counter({
help: 'Number of person merge final failures.',
})

const CASE_SENSITIVE_ILLEGAL_IDS = new Set(['[object Object]', 'NaN', 'None', 'none', 'null', '0', 'undefined'])
const CASE_SENSITIVE_ILLEGAL_IDS = new Set([
'[object Object]',
'NaN',
'None',
'none',
'null',
'"null"',
'0',
'"0"',
'undefined',
'"undefined"',
])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to do all of these single or double quoted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that... looking in the DB we only see them double quoted, but I guess that doesn't mean we'd never see them single quoted 🤔


const isDistinctIdIllegal = (id: string): boolean => {
return id.trim() === '' || CASE_INSENSITIVE_ILLEGAL_IDS.has(id.toLowerCase()) || CASE_SENSITIVE_ILLEGAL_IDS.has(id)
Expand Down