-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update base postgres to version 15 #17159
Conversation
We do need to land this before upgrading cloud, but this will require a manual call to
There are third-party postgres images that do automatically run pg_upgrade, but I'm not sure we want to go there. |
This is getting really hard i have tried different approaches and the issue is that for the pg_upgrade we need both pg12 and pg15 binaries, and the alpine image does not let me have both versions. Is this something we need to support and can people recreate the hobby deployment again? |
Another option is to have two containers running one for pg12 and another for pg15 and do the upgrade and switch the volumes, if is worth having this process i can try it tomorrow. |
We could move forward for now by overriding the image in docker-compose.hobby.yml to pin hobby to 12 while we figure it out, but still run our tests on 15. One low-effort way forward would be to switch to using the pgautoupgrade image that's a drop-in replacement image that runs Ideally we could run it once in the upgrade-hobby script, or add a warning to run it manually with a one-liner example. cc @fuziontech as the person with the most context on the hobby deploy and the upgrade script. |
I have pinned pg12 for the hobby deployment, please let me know how it looks for you. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Co-authored-by: Xavier Vello <[email protected]>
Problem
POstgres 12 is an old version and will lose support on AWS, so we are upgrading to pg 15.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?