feat(insights): keep configuration when navigating between insights

[thmsobrmlr]

Problem

Users want to switch from one query to another while keeping relevant configuration.

Changes

This PR re-adds said functionality.

(Potential) Follow-ups

• An error is thrown when switching from trends -> funnels -> trends with the compare option enabled. The reason for this is that the results are still based on the funnel response for a brief moment. Once this is fixed, the compare option can be enabled here as well.
• Event and action nodes include math properties which are only supported in some insights e.g. trends, but not in others e.g. funnels. Not all math properties supported in trends are supported in stickiness insights e.g. count per user average. Should we have different types for them and convert this accordingly? We seem to handle this well backend side, but frontend side is broken in some cases e.g. stickiness insight with unsupported math type.
  In the same spirit retentionFilter.target_entity and returning_entity should not have an order property.

How did you test this code?

Added tests and locally, with 👀

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[Twixes]

I like the approach here. Just found one bug: The configuration is kept as expected when a saved insight is loaded and immediately switched to a different type – but it's not kept when I first load the saved insights page and get to that same insight from there.

[thmsobrmlr]

Awesome catches @Twixes, thanks for the thorough look!

Just found one bug: The configuration is kept as expected when a saved insight is loaded and immediately switched to a different type – but it's not kept when I first load the saved insights page and get to that same insight from there.

This is because the insightDataLogic isn't mounted yet when insightLogic calls setInsight and so the respective listener doesn't fire. I've added a query cache update in insightNavLogic's afterMount.

There'd be an alternative approach that removes the problematic code altogether, simplifying a bit what happens when loading an insight. I've been trying it out here #18346, but am a bit worried about unintended effects of this.

[posthog-bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (wasn't pushed!)
• webkit: 0 added, 2 modified, 0 deleted (wasn't pushed!)

Triggered by this commit.

👉 Review this PR's diff of snapshots.