Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix CI for forks #16776

Merged
merged 21 commits into from
Jul 28, 2023
Merged

ci: Fix CI for forks #16776

merged 21 commits into from
Jul 28, 2023

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jul 26, 2023

Problem

A few CI checks are failing on PRs from forks (e.g. see #16542).

Changes

Fixing this.

@nategrift
Copy link
Contributor

Love this and very helpful, thank you!

@Twixes Twixes force-pushed the new-color branch 7 times, most recently from d775499 to dc1e85f Compare July 27, 2023 19:06
@Twixes Twixes marked this pull request as ready for review July 28, 2023 09:23
inputs:
python-version:
required: true
type: string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action inputs don't actually have a type parameter (they're all strings for GitHub)

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're so good at this tricky CI fangling 💖

I guess the real test is in a fork once this is in... :shipit:

@Twixes
Copy link
Member Author

Twixes commented Jul 28, 2023

This is a fork @pauldambra ;) Otherwise I'd have no idea if this makes sense

@pauldambra
Copy link
Member

OH MY GOD 🥇

@neilkakkar
Copy link
Collaborator

@nategrift once this is in, can you merge master into your PRs so we can merge? :)

@Twixes Twixes merged commit 8fd0f7a into PostHog:master Jul 28, 2023
@Twixes Twixes deleted the new-color branch July 28, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants