style(3000): Use new Central icons #16463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
Twixes
force-pushed
the
3000-icons
branch
2 times, most recently
from
5a45d12 to
7555ac8
Compare
daibhin
reviewed
Oct 13, 2023
| @@ -1,4 +1,4 @@ | |||
| lockfileVersion: '6.0' | |||
| lockfileVersion: '6.1' | |||
There was a problem hiding this comment.
Never sure what this flopping means 🤷
There was a problem hiding this comment.
I think some people (git blames – in this case, @pauldambra – judgmental look) have a slightly older version of pnpm installed, so we go back to 6.0. But they're the same, so this doesn't matter at all
|
Oops, fixed! 😄 @daibhin |
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
daibhin
approved these changes
Oct 13, 2023
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
daibhin
pushed a commit
that referenced
this pull request
Oct 23, 2023
* style(3000): Use new Central icons * Use prefixed icons * Use new icons * Remove `width` rule * Change Lemon `IconNotebook` to Material * Fix icon width * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Fix notebook icon coloring * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Starting to wean off Material icons and using Central. This updates the 3000 navigation to use new icons from
@posthog/icons.(the annotation and events ones aren't the final ones yet, need to add those to
@posthog/icons)