Skip to content

Commit

Permalink
fix: add keyboard shortcut to inside button on search result preview (#…
Browse files Browse the repository at this point in the history
…27071)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
adamleithp and github-actions[bot] authored Dec 19, 2024
1 parent 3843cc0 commit ffe4e9d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
10 changes: 1 addition & 9 deletions frontend/src/lib/components/CommandBar/SearchResultPreview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,10 @@ export const SearchResultPreview = (): JSX.Element | null => {
onClick={() => {
openResult(activeResultIndex)
}}
tooltip={
<>
Open <KeyboardShortcut enter />
</>
}
aria-label="Open search result"
>
Open
<span className="mr-1">Open</span> <KeyboardShortcut enter />
</LemonButton>
<div>
<KeyboardShortcut enter /> Open
</div>
</div>
</div>
</div>
Expand Down
5 changes: 0 additions & 5 deletions frontend/src/lib/lemon-ui/LemonInput/LemonInput.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,6 @@
// NOTE Design: Search inputs are given a specific small width
max-width: 240px;
border-radius: 0;

// Add a focus ring to the element (not the input) when focused
&:has(:focus-visible) {
outline: -webkit-focus-ring-color auto 1px;
}
}

&.LemonInput--type-number {
Expand Down

0 comments on commit ffe4e9d

Please sign in to comment.