show Other/None in actors modal

PostHog · Mar 21, 2024 · fce1815 · fce1815
1 parent 076732f
commit fce1815
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/posthog/hogql_queries/insights/trends/trends_query_runner.py b/posthog/hogql_queries/insights/trends/trends_query_runner.py
@@ -23,7 +23,6 @@
 from posthog.hogql.query import execute_hogql_query
 from posthog.hogql.timings import HogQLTimings
 from posthog.hogql_queries.insights.trends.breakdown_values import (
-    BREAKDOWN_NULL_NUMERIC_LABEL,
     BREAKDOWN_NULL_STRING_LABEL,
     BREAKDOWN_OTHER_NUMERIC_LABEL,
     BREAKDOWN_OTHER_STRING_LABEL,
@@ -240,14 +239,10 @@ def to_actors_query_options(self) -> InsightActorsQueryOptionsResponse:
                     cohort_name = "all users" if str(value) == "0" else Cohort.objects.get(pk=value).name
                     label = cohort_name
                     value = value
-                elif value == BREAKDOWN_OTHER_STRING_LABEL or value == BREAKDOWN_OTHER_NUMERIC_LABEL:
-                    # label = "Other"
-                    # value = BREAKDOWN_OTHER_STRING_LABEL
-                    continue  # TODO: Add support for "other" breakdowns
-                elif value == BREAKDOWN_NULL_STRING_LABEL or value == BREAKDOWN_NULL_NUMERIC_LABEL:
-                    # label = "Null"
-                    # value = BREAKDOWN_NULL_STRING_LABEL
-                    continue  # TODO: Add support for "null" breakdowns
+                elif value == BREAKDOWN_OTHER_STRING_LABEL:
+                    label = "Other (Groups all remaining values)"
+                elif value == BREAKDOWN_NULL_STRING_LABEL:
+                    label = "None (No value)"
                 elif is_boolean_breakdown:
                     label = self._convert_boolean(value)
                 else: