fix completed experiments also showing up in launched list

PostHog · Dec 30, 2024 · fab1885 · fab1885
1 parent 9002bfe
commit fab1885
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/posthog/tasks/periodic_digest.py b/posthog/tasks/periodic_digest.py
@@ -75,7 +75,7 @@ def get_teams_with_new_playlists(end: datetime, begin: datetime) -> QuerySet:
 
 
 def get_teams_with_new_experiments_launched(end: datetime, begin: datetime) -> QuerySet:
-    return Experiment.objects.filter(start_date__gt=begin, start_date__lte=end).values(
+    return Experiment.objects.filter(start_date__gt=begin, start_date__lte=end, end_date__isnull=True).values(
         "team_id", "name", "id", "start_date"
     )
 

diff --git a/posthog/tasks/test/test_periodic_digest.py b/posthog/tasks/test/test_periodic_digest.py
@@ -116,8 +116,8 @@ def test_periodic_digest_report(self, mock_capture: MagicMock) -> None:
             completed_experiment = Experiment.objects.create(
                 team=self.team,
                 name="Completed Experiment",
-                start_date=now() + timedelta(days=1),
-                end_date=now() + timedelta(days=6),
+                start_date=now() + timedelta(days=6),
+                end_date=now() + timedelta(days=7),
                 feature_flag=flag_for_completed_experiment,
             )