Skip to content

Commit

Permalink
don't think these are needed either
Browse files Browse the repository at this point in the history
  • Loading branch information
tkaemming committed Aug 26, 2024
1 parent 3cb47f2 commit faa3416
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions posthog/hogql/printer.py
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ def resolve_field_type(expr: ast.Expr) -> ast.Type | None:
return f"not({property_source.has_expr})"

printed_expr = f"equals({property_source.value_expr}, {self.visit(constant_expr)})"
if constant_expr.value == "": # TODO: check type?
if constant_expr.value == "":
# If we're comparing to an empty string literal, we need to disambiguate this from the default value
# for the ``Map(String, String)`` type used for storing property group values by also ensuring that
# the property key is present in the map. If this is in a ``WHERE`` clause, this also ensures we can
Expand Down Expand Up @@ -701,7 +701,7 @@ def resolve_field_type(expr: ast.Expr) -> ast.Type | None:
return None # only optimize constants for now, see above
elif expr.value is None:
node.right.exprs.remove(expr)
elif expr.value == "": # XXX: check type?
elif expr.value == "":
default_value_expr = expr
node.right.exprs.remove(expr)
if len(node.right.exprs) > 0:
Expand Down

0 comments on commit faa3416

Please sign in to comment.