fix(dashboards): Don't show erroring dashboards as not found (#21822)

PostHog · Apr 24, 2024 · f6681fc · f6681fc
1 parent 72bf3ab
commit f6681fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/frontend/src/scenes/dashboard/Dashboard.tsx b/frontend/src/scenes/dashboard/Dashboard.tsx
@@ -96,7 +96,7 @@ function DashboardScene(): JSX.Element {
         [setDashboardMode, dashboardMode, placement]
     )
 
-    if (!dashboard && !itemsLoading && receivedErrorsFromAPI) {
+    if (!dashboard && !itemsLoading && !receivedErrorsFromAPI) {
         return <NotFound object="dashboard" />
     }
 

diff --git a/frontend/src/scenes/dashboard/dashboardLogic.tsx b/frontend/src/scenes/dashboard/dashboardLogic.tsx
@@ -216,7 +216,7 @@ export const dashboardLogic = kea<dashboardLogicType>([
                         return dashboard
                     } catch (error: any) {
                         if (error.status === 404) {
-                            throw new Error('Dashboard not found')
+                            return null
                         }
                         throw error
                     }