fix(surveys): fix nps score decimal (#18237)

* fixed decimal * fix
PostHog · Oct 27, 2023 · f393cc7 · f393cc7
1 parent 51f256e
commit f393cc7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/frontend/src/scenes/surveys/SurveyView.tsx b/frontend/src/scenes/surveys/SurveyView.tsx
@@ -12,7 +12,7 @@ import { surveyLogic } from './surveyLogic'
 import { surveysLogic } from './surveysLogic'
 import { PageHeader } from 'lib/components/PageHeader'
 import { SurveyReleaseSummary } from './Survey'
-import { ChartDisplayType, PropertyFilterType, PropertyOperator, Survey, SurveyQuestionType, SurveyType } from '~/types'
+import { PropertyFilterType, PropertyOperator, Survey, SurveyQuestionType, SurveyType } from '~/types'
 import { SurveyAPIEditor } from './SurveyAPIEditor'
 import { NodeKind } from '~/queries/schema'
 import { dayjs } from 'lib/dayjs'
@@ -271,6 +271,7 @@ export function SurveyResult({ disableEventsTable }: { disableEventsTable?: bool
                                         <div className="text-4xl font-bold">{surveyNPSScore}</div>
                                         <div className="font-semibold text-muted-alt mb-2">Total NPS Score</div>
                                         {featureFlags[FEATURE_FLAGS.SURVEYS_RESULTS_VISUALIZATIONS] && (
+                                            // TODO: rework this to show nps scores over time
                                             <SurveyNPSResults survey={survey as Survey} />
                                         )}
                                     </>
@@ -383,7 +384,6 @@ function SurveyNPSResults({ survey }: { survey: Survey }): JSX.Element {
                         ],
                         trendsFilter: {
                             formula: '(A / (A+B+C) * 100) - (C / (A+B+C)* 100)',
-                            display: ChartDisplayType.ActionsLineGraphCumulative,
                         },
                     },
                 }}

diff --git a/frontend/src/scenes/surveys/surveyLogic.tsx b/frontend/src/scenes/surveys/surveyLogic.tsx
@@ -653,7 +653,7 @@ export const surveyLogic = kea<surveyLogicType>([
                         const passives = questionResults.slice(7, 9).reduce((a, b) => a + b, 0)
                         const detractors = questionResults.slice(0, 7).reduce((a, b) => a + b, 0)
                         const npsScore = ((promoters - detractors) / (promoters + passives + detractors)) * 100
-                        return npsScore
+                        return npsScore.toFixed(1)
                     }
                 }
             },