remove GlobalFiltersTitle

PostHog · Nov 22, 2023 · f32365b · f32365b
1 parent f048e19
commit f32365b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 37 deletions.
diff --git a/frontend/src/queries/nodes/InsightViz/GlobalAndOrFilters.tsx b/frontend/src/queries/nodes/InsightViz/GlobalAndOrFilters.tsx
@@ -34,7 +34,6 @@ export function GlobalAndOrFilters({ insightProps }: EditorFilterProps): JSX.Ele
             setQuery={updateQuerySource}
             eventNames={getAllEventNames(querySource as TrendsQuery | StickinessQuery, allActions)}
             taxonomicGroupTypes={taxonomicGroupTypes}
-            noTitle
         />
     )
 }
diff --git a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.tsx b/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.tsx
@@ -5,7 +5,6 @@ import './PropertyGroupFilters.scss'
 import { propertyGroupFilterLogic } from './propertyGroupFilterLogic'
 import { PropertyFilters } from 'lib/components/PropertyFilters/PropertyFilters'
 import { isPropertyGroupFilterLike } from 'lib/components/PropertyFilters/utils'
-import { GlobalFiltersTitle } from 'scenes/insights/common'
 import { IconCopy, IconDelete, IconPlusMini } from 'lib/lemon-ui/icons'
 import { TestAccountFilter } from '../filters/TestAccountFilter'
 import { LemonButton, LemonDivider } from '@posthog/lemon-ui'
@@ -21,7 +20,6 @@ type PropertyGroupFiltersProps = {
     pageKey: string
     eventNames?: string[]
     taxonomicGroupTypes?: TaxonomicFilterGroupType[]
-    noTitle?: boolean
 }
 
 export function PropertyGroupFilters({
@@ -31,7 +29,6 @@ export function PropertyGroupFilters({
     pageKey,
     eventNames = [],
     taxonomicGroupTypes,
-    noTitle,
 }: PropertyGroupFiltersProps): JSX.Element {
     const logicProps = { query, setQuery, pageKey }
     const { propertyGroupFilter } = useValues(propertyGroupFilterLogic(logicProps))
@@ -44,7 +41,7 @@ export function PropertyGroupFilters({
         setPropertyFilters,
     } = useActions(propertyGroupFilterLogic(logicProps))
 
-    const showHeader = !noTitle || (propertyGroupFilter.type && propertyGroupFilter.values.length > 1)
+    const showHeader = propertyGroupFilter.type && propertyGroupFilter.values.length > 1
 
     return (
         <div className="space-y-2 PropertyGroupFilters">
@@ -54,7 +51,6 @@ export function PropertyGroupFilters({
                     {showHeader ? (
                         <>
                             <div className="flex items-center justify-between">
-                                {!noTitle ? <GlobalFiltersTitle orFiltering={true} /> : null}
                                 {propertyGroupFilter.type && propertyGroupFilter.values.length > 1 && (
                                     <AndOrFilterSelect
                                         value={propertyGroupFilter.type}

diff --git a/frontend/src/scenes/insights/common.tsx b/frontend/src/scenes/insights/common.tsx