More sensible defaults for PeriodicTask.

PostHog · Dec 6, 2023 · f239cd9 · f239cd9
1 parent 6c4b2d9
commit f239cd9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/plugin-server/src/main/pluginsServer.ts b/plugin-server/src/main/pluginsServer.ts
@@ -437,7 +437,7 @@ export async function startPluginsServer(
             const postgres = hub?.postgres ?? new PostgresRouter(serverConfig)
             const kafkaProducer = hub?.kafkaProducer ?? (await createKafkaProducerWrapper(serverConfig))
 
-            personOverridesPeriodicTask = new DeferredPersonOverrideWorker(postgres, kafkaProducer).runTask()
+            personOverridesPeriodicTask = new DeferredPersonOverrideWorker(postgres, kafkaProducer).runTask(5000)
             personOverridesPeriodicTask.promise.catch(async () => {
                 status.error('⚠️', 'Person override worker task crashed! Requesting shutdown...')
                 await closeJobs()

diff --git a/plugin-server/src/utils/periodic-task.ts b/plugin-server/src/utils/periodic-task.ts
@@ -6,7 +6,7 @@ export class PeriodicTask {
     private running = true
     private abortController: AbortController
 
-    constructor(task: () => Promise<void> | void, intervalMs = 1000, minimumWaitMs = 1000) {
+    constructor(task: () => Promise<void> | void, intervalMs: number, minimumWaitMs = 0) {
         this.abortController = new AbortController()
 
         const abortRequested = new Promise((resolve) => {

diff --git a/plugin-server/src/worker/ingestion/person-state.ts b/plugin-server/src/worker/ingestion/person-state.ts
@@ -808,12 +808,12 @@ export class DeferredPersonOverrideWorker {
         })
     }
 
-    public runTask(): PeriodicTask {
+    public runTask(intervalMs: number): PeriodicTask {
         return new PeriodicTask(async () => {
             status.debug('👥', 'Processing pending overrides...')
             const overridesCount = await this.processPendingOverrides()
             ;(overridesCount > 0 ? status.info : status.debug)('👥', `Processed ${overridesCount} pending overrides.`)
-        })
+        }, intervalMs)
     }
 }
 

diff --git a/plugin-server/tests/utils/periodic-task.test.ts b/plugin-server/tests/utils/periodic-task.test.ts
@@ -4,7 +4,7 @@ describe('PeriodicTask', () => {
     describe('updates completion status', () => {
         it('on success', async () => {
             const fn = jest.fn()
-            const task = new PeriodicTask(fn)
+            const task = new PeriodicTask(fn, 1000)
             expect(fn).toBeCalled()
             expect(task.isRunning()).toEqual(true)
             await task.stop()
@@ -15,7 +15,7 @@ describe('PeriodicTask', () => {
             const fn = jest.fn(() => {
                 throw new Error()
             })
-            const task = new PeriodicTask(fn)
+            const task = new PeriodicTask(fn, 1000)
             expect(fn).toBeCalled()
             await task.stop()
             expect(task.isRunning()).toEqual(false)