fix(lemon-ui): Logos as button icons no longer translucent (#23996)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Jul 26, 2024 · eedd19a · eedd19a
1 parent 940a037
commit eedd19a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--light.png b/frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--light.png
diff --git a/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss b/frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
@@ -55,7 +55,6 @@
     --lemon-button-height: 2.3125rem;
     --lemon-button-gap: 0.5rem;
     --lemon-button-icon-opacity: 0.8;
-    --lemon-button-profile-picture-opacity: 0.9; // Profile pictures must be more prominent than icons
     --lemon-button-color: var(--text-3000);
 
     // column-gap: 4px;
@@ -119,14 +118,9 @@
             font-size: var(--lemon-button-icon-size);
             transition: color 200ms ease;
 
-            > * {
+            .LemonIcon {
                 opacity: var(--lemon-button-icon-opacity);
             }
-
-            > .ProfilePicture,
-            > .Lettermark {
-                opacity: var(--lemon-button-profile-picture-opacity);
-            }
         }
     }
 
@@ -139,7 +133,6 @@
     &:hover:not([aria-disabled='true']),
     &:not([aria-disabled='true']):active {
         --lemon-button-icon-opacity: 0.75;
-        --lemon-button-profile-picture-opacity: 1;
     }
 
     &.LemonButton--full-width {

diff --git a/frontend/src/lib/lemon-ui/LemonSegmentedButton/LemonSegmentedButton.scss b/frontend/src/lib/lemon-ui/LemonSegmentedButton/LemonSegmentedButton.scss
@@ -68,7 +68,6 @@
 
             .LemonButton {
                 --lemon-button-icon-opacity: 1;
-                --lemon-button-profile-picture-opacity: 1;
             }
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,6 @@ @@
                 .LemonButton {
                     --lemon-button-icon-opacity: 1;
-                    --lemon-button-profile-picture-opacity: 1;
                 }
             }
@@ Expand Down @@