fix(batch-exports): add more non-retryable errors (#22161)

PostHog · May 7, 2024 · ed845fa · ed845fa
1 parent a1e089a
commit ed845fa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/posthog/temporal/batch_exports/bigquery_batch_export.py b/posthog/temporal/batch_exports/bigquery_batch_export.py
@@ -440,8 +440,11 @@ async def run(self, inputs: BigQueryBatchExportInputs):
                 "RefreshError",
                 # Usually means the dataset or project doesn't exist.
                 "NotFound",
-                # Raised when something about dataset is wrong (not alphanumeric, too long, etc)
+                # Raised when something about dataset is wrong (not alphanumeric, too long, etc).
                 "BadRequest",
+                # Raised when table_id isn't valid. Sadly, `ValueError` is rather generic, but we
+                # don't anticipate a `ValueError` thrown from our own export code.
+                "ValueError",
             ],
             finish_inputs=finish_inputs,
         )
diff --git a/posthog/temporal/batch_exports/postgres_batch_export.py b/posthog/temporal/batch_exports/postgres_batch_export.py
@@ -448,6 +448,8 @@ async def run(self, inputs: PostgresBatchExportInputs):
                 "InvalidSchemaName",
                 # Missing permissions to, e.g., insert into table.
                 "InsufficientPrivilege",
+                # Issue with exported data compared to schema, retrying won't help.
+                "NotNullViolation",
             ],
             finish_inputs=finish_inputs,
             # Disable heartbeat timeout until we add heartbeat support.