feat(hogql): implement include_recordings for funnel actors (#20503)

PostHog · Feb 28, 2024 · ecaccb4 · ecaccb4
1 parent 08255db
commit ecaccb4
Show file tree

Hide file tree

Showing 20 changed files with 2,227 additions and 465 deletions.
diff --git a/frontend/src/scenes/funnels/funnelPersonsModalLogic.ts b/frontend/src/scenes/funnels/funnelPersonsModalLogic.ts
@@ -102,8 +102,9 @@ export const funnelPersonsModalLogic = kea<funnelPersonsModalLogicType>([
                     kind: NodeKind.InsightActorsQuery,
                     source: values.querySource!,
                     funnelStep: converted ? stepNo : -stepNo,
+                    includeRecordings: true,
                 }
-                openPersonsModal({ title, query })
+                openPersonsModal({ title, query, additionalSelect: { matched_recordings: 'matched_recordings' } })
             } else {
                 openPersonsModal({
                     url: generateBaselineConversionUrl(converted ? step.converted_people_url : step.dropped_people_url),
@@ -134,8 +135,9 @@ export const funnelPersonsModalLogic = kea<funnelPersonsModalLogicType>([
                     source: values.querySource!,
                     funnelStep: converted ? stepNo : -stepNo,
                     funnelStepBreakdown: series.breakdown_value,
+                    includeRecordings: true,
                 }
-                openPersonsModal({ title, query })
+                openPersonsModal({ title, query, additionalSelect: { matched_recordings: 'matched_recordings' } })
             } else {
                 openPersonsModal({
                     url: converted ? series.converted_people_url : series.dropped_people_url,

diff --git a/posthog/api/test/__snapshots__/test_query.ambr b/posthog/api/test/__snapshots__/test_query.ambr
@@ -166,6 +166,7 @@
          events.elements_chain AS elements_chain,
          toTimeZone(events.created_at, 'UTC') AS created_at,
          events.`$session_id` AS `$session_id`,
+         events.`$window_id` AS `$window_id`,
          events.`$group_0` AS `$group_0`,
          events.`$group_1` AS `$group_1`,
          events.`$group_2` AS `$group_2`,

diff --git a/posthog/hogql/database/schema/events.py b/posthog/hogql/database/schema/events.py
@@ -67,6 +67,7 @@ class EventsTable(Table):
         "elements_chain": StringDatabaseField(name="elements_chain"),
         "created_at": DateTimeDatabaseField(name="created_at"),
         "$session_id": StringDatabaseField(name="$session_id"),
+        "$window_id": StringDatabaseField(name="$window_id"),
         # Lazy table that adds a join to the persons table
         "pdi": LazyJoin(
             from_field="distinct_id",

diff --git a/posthog/hogql/database/test/__snapshots__/test_database.ambr b/posthog/hogql/database/test/__snapshots__/test_database.ambr
@@ -35,6 +35,10 @@
               "key": "$session_id",
               "type": "string"
           },
+          {
+              "key": "$window_id",
+              "type": "string"
+          },
           {
               "key": "pdi",
               "type": "lazy_table",
@@ -801,6 +805,10 @@
               "key": "$session_id",
               "type": "string"
           },
+          {
+              "key": "$window_id",
+              "type": "string"
+          },
           {
               "key": "pdi",
               "type": "lazy_table",