chore: hide delete option for notebook template (#19841)

PostHog · Jan 18, 2024 · e86acf7 · e86acf7
1 parent 318907d
commit e86acf7
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 38 deletions.
diff --git a/frontend/__snapshots__/scenes-app-notebooks--notebooks-list--light.png b/frontend/__snapshots__/scenes-app-notebooks--notebooks-list--light.png
diff --git a/frontend/src/scenes/notebooks/NotebookMenu.tsx b/frontend/src/scenes/notebooks/NotebookMenu.tsx
@@ -21,35 +21,31 @@ export function NotebookMenu({ shortId }: NotebookLogicProps): JSX.Element {
         <LemonMenu
             items={[
                 {
-                    items: [
-                        {
-                            label: 'Export JSON',
-                            icon: <IconExport />,
-                            onClick: () => exportJSON(),
-                        },
-                        {
-                            label: 'History',
-                            icon: <IconClock />,
-                            onClick: () => setShowHistory(!showHistory),
-                        },
-                        {
-                            label: 'Share',
-                            icon: <IconShare />,
-                            onClick: () => openNotebookShareDialog({ shortId }),
-                        },
-                        !isLocalOnly &&
-                            !notebook?.is_template && {
-                                label: 'Delete',
-                                icon: <IconDelete />,
-                                status: 'danger',
-
-                                onClick: () => {
-                                    notebooksModel.actions.deleteNotebook(shortId, notebook?.title)
-                                    router.actions.push(urls.notebooks())
-                                },
-                            },
-                    ],
+                    label: 'Export JSON',
+                    icon: <IconExport />,
+                    onClick: () => exportJSON(),
+                },
+                {
+                    label: 'History',
+                    icon: <IconClock />,
+                    onClick: () => setShowHistory(!showHistory),
+                },
+                {
+                    label: 'Share',
+                    icon: <IconShare />,
+                    onClick: () => openNotebookShareDialog({ shortId }),
                 },
+                !isLocalOnly &&
+                    !notebook?.is_template && {
+                        label: 'Delete',
+                        icon: <IconDelete />,
+                        status: 'danger',
+
+                        onClick: () => {
+                            notebooksModel.actions.deleteNotebook(shortId, notebook?.title)
+                            router.actions.push(urls.notebooks())
+                        },
+                    },
             ]}
             actionable
         >

diff --git a/frontend/src/scenes/notebooks/NotebooksTable/NotebooksTable.tsx b/frontend/src/scenes/notebooks/NotebooksTable/NotebooksTable.tsx
@@ -65,21 +65,20 @@ export function NotebooksTable(): JSX.Element {
         >,
         {
             render: function Render(_, notebook) {
+                if (notebook.is_template) {
+                    return null
+                }
                 return (
                     <LemonMenu
                         items={[
                             {
-                                items: [
-                                    {
-                                        label: 'Delete',
-                                        icon: <IconDelete />,
-                                        status: 'danger',
+                                label: 'Delete',
+                                icon: <IconDelete />,
+                                status: 'danger',
 
-                                        onClick: () => {
-                                            notebooksModel.actions.deleteNotebook(notebook.short_id, notebook?.title)
-                                        },
-                                    },
-                                ],
+                                onClick: () => {
+                                    notebooksModel.actions.deleteNotebook(notebook.short_id, notebook?.title)
+                                },
                             },
                         ]}
                         actionable