Skip to content

Commit

Permalink
fix(a/b testing): posthog-3000 fixes (#19447)
Browse files Browse the repository at this point in the history
  • Loading branch information
jurajmajerik authored and fuziontech committed Jan 4, 2024
1 parent 8c82894 commit e30c13b
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 5 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions frontend/src/lib/components/Support/supportLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ export const TARGET_AREA_TO_NAME = {
data_management: 'Data Management',
data_warehouse: 'Data Warehouse',
ingestion: 'Event Ingestion',
experiments: 'Experiments',
experiments: 'A/B Testing',
feature_flags: 'Feature Flags',
analytics: 'Product Analytics (Insights, Dashboards, Annotations)',
session_replay: 'Session Replay (Recordings)',
toolbar: 'Toolbar & heatmaps',
toolbar: 'Toolbar & Heatmaps',
surveys: 'Surveys',
web_analytics: 'Web Analytics',
'posthog-3000': 'PostHog 3000',
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/scenes/experiments/Experiment.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@

.exp-description {
font-style: italic;
color: var(--muted);
}

.participants {
Expand Down Expand Up @@ -209,3 +208,10 @@
border: 1px solid var(--border);
border-radius: var(--radius);
}

.exp-flag-copy-label {
font-size: 11px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.5px;
}
18 changes: 16 additions & 2 deletions frontend/src/scenes/experiments/Experiment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,21 @@ export function Experiment(): JSX.Element {
}
/>
<div className="w-full pb-4">
<span className="exp-description">
<div>
{experiment.feature_flag && (
<>
<div className="exp-flag-copy-label">Feature flag</div>
<CopyToClipboardInline
iconStyle={{ color: 'var(--lemon-button-icon-opacity)' }}
className="font-normal text-sm"
description="feature flag key"
>
{experiment.feature_flag.key}
</CopyToClipboardInline>
</>
)}
</div>
<div className="mt-4 exp-description">
{isExperimentRunning ? (
<EditableField
multiline
Expand All @@ -641,7 +655,7 @@ export function Experiment(): JSX.Element {
) : (
<>{experiment.description || 'There is no description for this experiment.'}</>
)}
</span>
</div>
</div>
</div>
<div className="mb-4">
Expand Down

0 comments on commit e30c13b

Please sign in to comment.