chore(plugin-server): lazily json serialize some timeoutguard context

PostHog · Apr 3, 2024 · e15a798 · bretthoerner · Apr 4, 2024 · e15a798
1 parent 3eef870
commit e15a798
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/plugin-server/src/worker/ingestion/event-pipeline/runner.ts b/plugin-server/src/worker/ingestion/event-pipeline/runner.ts
@@ -165,12 +165,12 @@ export class EventPipelineRunner {
                 const sendToSentry = false
                 const timeout = timeoutGuard(
                     `Event pipeline step stalled. Timeout warning after ${this.hub.PIPELINE_STEP_STALLED_LOG_TIMEOUT} sec! step=${step.name} team_id=${teamId} distinct_id=${this.originalEvent.distinct_id}`,
-                    {
+                    () => ({
                         step: step.name,
                         event: JSON.stringify(this.originalEvent),
                         teamId: teamId,
                         distinctId: this.originalEvent.distinct_id,
-                    },
+                    }),
                     this.hub.PIPELINE_STEP_STALLED_LOG_TIMEOUT * 1000,
                     sendToSentry
                 )

diff --git a/plugin-server/src/worker/ingestion/process-event.ts b/plugin-server/src/worker/ingestion/process-event.ts
@@ -73,9 +73,10 @@ export class EventsProcessor {
         eventUuid: string
     ): Promise<PreIngestionEvent> {
         const singleSaveTimer = new Date()
-        const timeout = timeoutGuard('Still inside "EventsProcessor.processEvent". Timeout warning after 30 sec!', {
-            event: JSON.stringify(data),
-        })
+        const timeout = timeoutGuard(
+            'Still inside "EventsProcessor.processEvent". Timeout warning after 30 sec!',
+            () => ({ event: JSON.stringify(data) })
+        )
 
         let result: PreIngestionEvent | null = null
         try {

diff --git a/plugin-server/src/worker/ingestion/property-definitions-manager.ts b/plugin-server/src/worker/ingestion/property-definitions-manager.ts
@@ -95,9 +95,12 @@ export class PropertyDefinitionsManager {
         }
 
         const timer = new Date()
-        const timeout = timeoutGuard('Still running "updateEventNamesAndProperties". Timeout warning after 30 sec!', {
-            event: event,
-        })
+        const timeout = timeoutGuard(
+            'Still running "updateEventNamesAndProperties". Timeout warning after 30 sec!',
+            () => ({
+                event: event,
+            })
+        )
 
         try {
             const team: Team | null = await this.teamManager.fetchTeam(teamId)