fix: revert "feat: faster json parsing" (#19838)

Revert "feat: faster json parsing"
PostHog · Jan 18, 2024 · e049e2c · e049e2c
1 parent 4c9977b
commit e049e2c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 43 deletions.
diff --git a/plugin-server/package.json b/plugin-server/package.json
@@ -80,7 +80,6 @@
         "prom-client": "^14.2.0",
         "re2": "^1.20.3",
         "safe-stable-stringify": "^2.4.0",
-        "simdjson": "^0.9.2",
         "tail": "^2.2.6",
         "uuid": "^8.3.2",
         "v8-profiler-next": "^1.9.0",

diff --git a/plugin-server/pnpm-lock.yaml b/plugin-server/pnpm-lock.yaml
diff --git a/plugin-server/src/main/ingestion-queues/session-recording/utils.ts b/plugin-server/src/main/ingestion-queues/session-recording/utils.ts
@@ -2,7 +2,6 @@ import { captureException, captureMessage } from '@sentry/node'
 import { DateTime } from 'luxon'
 import { KafkaConsumer, Message, MessageHeader, PartitionMetadata, TopicPartition } from 'node-rdkafka'
 import path from 'path'
-import { parse } from 'simdjson'
 
 import { KAFKA_SESSION_RECORDING_SNAPSHOT_ITEM_EVENTS } from '../../../config/kafka-topics'
 import { PipelineEvent, RawEventMessage, RRWebEvent } from '../../../types'
@@ -177,13 +176,8 @@ export const parseKafkaMessage = async (
     let event: PipelineEvent
 
     try {
-        // we only read distinct_id, team_id, token, and data from the message payload
-        // data is read into event
-        // TODO: simd json can lazily parse json, so if we could avoid parsing "events" from the data
-        // we'd get the biggest perf win, since that is the potentially large "blob" of data
-        // see: https://github.com/luizperes/simdjson_nodejs?tab=readme-ov-file#parsing-a-json-string-lazily
-        messagePayload = parse(message.value.toString())
-        event = parse(messagePayload.data)
+        messagePayload = JSON.parse(message.value.toString())
+        event = JSON.parse(messagePayload.data)
     } catch (error) {
         return dropMessage('invalid_json', { error })
     }

diff --git a/plugin-server/tests/main/ingestion-queues/session-recording/utils.test.ts b/plugin-server/tests/main/ingestion-queues/session-recording/utils.test.ts
@@ -68,25 +68,7 @@ describe('session-recording utils', () => {
             )
             expect(parsedMessage).toEqual({
                 distinct_id: String(numericId),
-                events: [
-                    {
-                        data: {
-                            payload: {
-                                level: 'log',
-                                payload: ['"Hedgehog: Will \'jump\' for 2916.6666666666665ms"'],
-                                trace: [
-                                    'HedgehogActor.setAnimation (http://127.0.0.1:8000/static/toolbar.js?_ts=1693421010000:105543:17)',
-                                    'HedgehogActor.setRandomAnimation (http://127.0.0.1:8000/static/toolbar.js?_ts=1693421010000:105550:14)',
-                                    'HedgehogActor.update (http://127.0.0.1:8000/static/toolbar.js?_ts=1693421010000:105572:16)',
-                                    'loop (http://127.0.0.1:8000/static/toolbar.js?_ts=1693421010000:105754:15)',
-                                ],
-                            },
-                            plugin: 'rrweb/console@1',
-                        },
-                        timestamp: 1693422950693,
-                        type: 6,
-                    },
-                ],
+                events: expect.any(Array),
                 metadata: {
                     offset: 1,
                     partition: 1,
@@ -97,7 +79,6 @@ describe('session-recording utils', () => {
                 session_id: '018a47c2-2f4a-70a8-b480-5e51d8b8d070',
                 team_id: 1,
                 window_id: '018a47c2-2f4a-70a8-b480-5e52f5480448',
-                snapshot_source: undefined,
             })
         })