fix(insights): Move from GET to POST queries (#19859)

cypress/productAnalytics/index.ts

@@ -17,10 +17,10 @@ export const savedInsights = {
 }
 
 export function interceptInsightLoad(insightType: string): string {
-    cy.intercept('GET', /api\/projects\/\d+\/insights\/trend\/\?.*/).as('loadNewTrendsInsight')
-    cy.intercept('POST', /api\/projects\/\d+\/insights\/funnel\/?/).as('loadNewFunnelInsight')
-    cy.intercept('GET', /api\/projects\/\d+\/insights\/retention\/\?.*/).as('loadNewRetentionInsight')
-    cy.intercept('POST', /api\/projects\/\d+\/insights\/path\/?/).as('loadNewPathsInsight')
+    cy.intercept('POST', /api\/projects\/\d+\/insights\/trend\//).as('loadNewTrendsInsight')
+    cy.intercept('POST', /api\/projects\/\d+\/insights\/funnel\//).as('loadNewFunnelInsight')
+    cy.intercept('POST', /api\/projects\/\d+\/insights\/retention\//).as('loadNewRetentionInsight')
+    cy.intercept('POST', /api\/projects\/\d+\/insights\/path\//).as('loadNewPathsInsight')
     cy.intercept('POST', /api\/projects\/\d+\/query\//).as('loadNewQueryInsight')
 
     let networkInterceptAlias: string = ''

frontend/src/queries/query.ts

@@ -402,6 +402,25 @@ export function legacyInsightQueryURL({ filters, currentTeamId, refresh }: Legac
     }
 }
 
+export function legacyInsightQueryData({
+    filters,
+    currentTeamId,
+    refresh,
+}: LegacyInsightQueryParams): [string, Record<string, any>] {
+    const baseUrl = `api/projects/${currentTeamId}/insights`
+
+    if (isTrendsFilter(filters) || isStickinessFilter(filters) || isLifecycleFilter(filters)) {
+        return [`${baseUrl}/trend/`, { ...filterTrendsClientSideParams(filters), refresh }]
+    } else if (isRetentionFilter(filters)) {
+        return [`${baseUrl}/retention/`, { ...filters, refresh }]
+    } else if (isFunnelsFilter(filters)) {
+        return [`${baseUrl}/funnel/`, { ...filters, refresh }]
+    } else if (isPathsFilter(filters)) {
+        return [`${baseUrl}/path/`, { ...filters, refresh }]
+    }
+    throw new Error(`Unsupported insight type: ${filters.insight}`)
+}
+
 export function legacyInsightQueryExportContext({
     filters,
     currentTeamId,
@@ -442,16 +461,17 @@ export async function legacyInsightQuery({
     methodOptions,
     refresh,
 }: LegacyInsightQueryParams): Promise<[Response, string]> {
-    const apiUrl = legacyInsightQueryURL({ filters, currentTeamId, refresh })
+    const [apiUrl, data] = legacyInsightQueryData({ filters, currentTeamId, refresh })
     let fetchResponse: Response
-    if (isTrendsFilter(filters) || isStickinessFilter(filters) || isLifecycleFilter(filters)) {
-        fetchResponse = await api.getResponse(apiUrl, methodOptions)
-    } else if (isRetentionFilter(filters)) {
-        fetchResponse = await api.getResponse(apiUrl, methodOptions)
-    } else if (isFunnelsFilter(filters)) {
-        fetchResponse = await api.createResponse(apiUrl, filters, methodOptions)
-    } else if (isPathsFilter(filters)) {
-        fetchResponse = await api.createResponse(apiUrl, filters, methodOptions)
+    if (
+        isTrendsFilter(filters) ||
+        isStickinessFilter(filters) ||
+        isLifecycleFilter(filters) ||
+        isRetentionFilter(filters) ||
+        isFunnelsFilter(filters) ||
+        isPathsFilter(filters)
+    ) {
+        fetchResponse = await api.createResponse(apiUrl, data, methodOptions)
     } else {
         throw new Error(`Unsupported insight type: ${filters.insight}`)
     }

frontend/src/scenes/insights/EmptyStates/EmptyStates.stories.tsx

@@ -69,6 +69,8 @@ export const ValidationError: StoryFn = () => {
                 ctx.status(200),
                 ctx.json({ count: 1, results: [{ ...insight, result: null }] }),
             ],
+        },
+        post: {
             '/api/projects/:team_id/insights/:id': (_, __, ctx) => [
                 ctx.delay(100),
                 ctx.status(400),
@@ -92,6 +94,8 @@ export const EstimatedQueryExecutionTimeTooLong: StoryFn = () => {
                 ctx.status(200),
                 ctx.json({ count: 1, results: [{ ...insight, result: null }] }),
             ],
+        },
+        post: {
             '/api/projects/:team_id/insights/trend/': (_, __, ctx) => [
                 ctx.delay(100),
                 ctx.status(512),
@@ -120,6 +124,8 @@ export const LongLoading: StoryFn = () => {
                 ctx.status(200),
                 ctx.json({ count: 1, results: [{ ...insight, result: null }] }),
             ],
+        },
+        post: {
             '/api/projects/:team_id/insights/trend/': (_, __, ctx) => [
                 ctx.delay(86400000),
                 ctx.status(200),

posthog/api/insight.py

@@ -949,7 +949,7 @@ def calculate_funnel(self, request: request.Request) -> Dict[str, Any]:
     # - start_entity: (dict) specifies id and type of the entity to focus retention on
     # - **shared filter types
     # ******************************************
-    @action(methods=["GET"], detail=False)
+    @action(methods=["GET", "POST"], detail=False)
     def retention(self, request: request.Request, *args: Any, **kwargs: Any) -> Response:
         timings = HogQLTimings()
         try:
@@ -965,7 +965,7 @@ def retention(self, request: request.Request, *args: Any, **kwargs: Any) -> Resp
     def calculate_retention(self, request: request.Request) -> Dict[str, Any]:
         team = self.team
         data = {}
-        if not request.GET.get("date_from"):
+        if not request.GET.get("date_from") and not request.data.get("date_from"):
             data.update({"date_from": "-11d"})
         filter = RetentionFilter(data=data, request=request, team=self.team)
         base_uri = request.build_absolute_uri("/")