date operators on cohorts

PostHog · Aug 5, 2024 · da8ab32 · da8ab32
1 parent 06df730
commit da8ab32
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/frontend/src/scenes/cohorts/CohortFilters/constants.tsx b/frontend/src/scenes/cohorts/CohortFilters/constants.tsx
@@ -39,6 +39,7 @@ import {
     FilterLogicalOperator,
     PropertyMathType,
     PropertyOperator,
+    SingleFieldDateType,
     TimeUnitType,
     ValueOptionType,
 } from '~/types'
@@ -200,6 +201,21 @@ export const FIELD_VALUES: Record<FieldOptionsType, FieldValues> = {
             },
         },
     },
+    [FieldOptionsType.SingleFieldDateOperators]: {
+        label: 'Date Operators',
+        type: FieldOptionsType.SingleFieldDateOperators,
+        values: {
+            [SingleFieldDateType.IsDateExact]: {
+                label: 'on the date',
+            },
+            [SingleFieldDateType.IsDateAfter]: {
+                label: 'since',
+            },
+            [SingleFieldDateType.IsDateBefore]: {
+                label: 'before',
+            },
+        },
+    },
     [FieldOptionsType.MathOperators]: {
         label: 'Operators',
         type: FieldOptionsType.MathOperators,
@@ -861,7 +877,12 @@ export const renderField: Record<FilterType, (props: CohortFieldProps) => JSX.El
         return <CohortSelectorField {...p} fieldOptionGroupTypes={[FieldOptionsType.DateOperators]} />
     },
     [FilterType.MathOperator]: function _renderField(p) {
-        return <CohortSelectorField {...p} fieldOptionGroupTypes={[FieldOptionsType.MathOperators]} />
+        return (
+            <CohortSelectorField
+                {...p}
+                fieldOptionGroupTypes={[FieldOptionsType.MathOperators, FieldOptionsType.SingleFieldDateOperators]}
+            />
+        )
     },
     [FilterType.EventsAndActionsMathOperator]: function _renderField(p) {
         return <CohortSelectorField {...p} fieldOptionGroupTypes={[FieldOptionsType.EventsAndActionsMathOperators]} />

diff --git a/frontend/src/scenes/cohorts/CohortFilters/types.ts b/frontend/src/scenes/cohorts/CohortFilters/types.ts
@@ -42,6 +42,7 @@ export enum FieldOptionsType {
     LifecycleBehavioral = 'lifecycleBehavioral',
     TimeUnits = 'timeUnits',
     DateOperators = 'dateOperators',
+    SingleFieldDateOperators = 'singleFieldDateOperators',
     MathOperators = 'mathOperators',
     ValueOptions = 'valueOptions',
     EventsAndActionsMathOperators = 'eventsAndActionsMathOperators',

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -3500,6 +3500,12 @@ export enum DateOperatorType {
     IsNotSet = 'is_not_set',
 }
 
+export enum SingleFieldDateType {
+    IsDateExact = 'is_date_exact',
+    IsDateBefore = 'is_date_before',
+    IsDateAfter = 'is_date_after',
+}
+
 export enum ValueOptionType {
     MostRecent = 'most_recent',
     Previous = 'previous',