fix(insights): hide delete series button when there is a single series

PostHog · Aug 9, 2024 · d857cb3 · d857cb3
1 parent 6d7124c
commit d857cb3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/cypress/e2e/trends.cy.ts b/cypress/e2e/trends.cy.ts
@@ -170,4 +170,8 @@ describe('Trends', () => {
         cy.get('[data-attr=math-monthly_active-0]').trigger('mouseenter') // Activate warning tooltip
         cy.get('.Tooltip').contains('we recommend using "Unique users" here instead').should('exist')
     })
+
+    it('Does not show delete button on single series insight', () => {
+        cy.get('[data-attr=delete-prop-filter-0]').should('not.exist')
+    })
 })
diff --git a/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts b/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts
@@ -188,6 +188,15 @@ export const actionsAndEventsToSeries = (
     return series
 }
 
+export const actionsAndEventsCount = ({
+    actions,
+    events,
+    data_warehouse,
+    new_entity,
+}: FilterTypeActionsAndEvents): number => {
+    return [...(actions || []), ...(events || []), ...(data_warehouse || []), ...(new_entity || [])].length
+}
+
 /**
  * Converts `hidden_legend_keys` in trends and stickiness insights to an array of hidden indexes.
  * Example: `{1: true, 2: false}` will become `[1]`.

diff --git a/frontend/src/queries/nodes/InsightViz/TrendsSeries.tsx b/frontend/src/queries/nodes/InsightViz/TrendsSeries.tsx
@@ -14,7 +14,7 @@ import { FunnelsQuery, LifecycleQuery, StickinessQuery, TrendsQuery } from '~/qu
 import { isInsightQueryNode } from '~/queries/utils'
 import { FilterType } from '~/types'
 
-import { actionsAndEventsToSeries } from '../InsightQuery/utils/filtersToQueryNode'
+import { actionsAndEventsCount, actionsAndEventsToSeries } from '../InsightQuery/utils/filtersToQueryNode'
 import { queryNodeToFilter } from '../InsightQuery/utils/queryNodeToFilter'
 
 export function TrendsSeries(): JSX.Element | null {
@@ -90,6 +90,7 @@ export function TrendsSeries(): JSX.Element | null {
                     TaxonomicFilterGroupType.Actions,
                     TaxonomicFilterGroupType.DataWarehouse,
                 ]}
+                hideDeleteBtn={actionsAndEventsCount(filters as any) === 1}
             />
         </>
     )

diff --git a/frontend/src/scenes/insights/filters/ActionFilter/ActionFilterRow/ActionFilterRow.tsx b/frontend/src/scenes/insights/filters/ActionFilter/ActionFilterRow/ActionFilterRow.tsx
@@ -346,7 +346,7 @@ export function ActionFilterRow({
         <LemonButton
             key="delete"
             icon={<IconTrash />}
-            // title="Delete graph series"
+            title="Delete graph series"
             data-attr={`delete-prop-filter-${index}`}
             noPadding={!enablePopup}
             onClick={() => {