chore(data-warehouse): Make external tab the focus (#17469)

* flip tabs * revert * revert
PostHog · Sep 15, 2023 · d1738aa · d1738aa
1 parent 20e642d
commit d1738aa
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 14 deletions.
diff --git a/frontend/src/scenes/appScenes.ts b/frontend/src/scenes/appScenes.ts
@@ -38,7 +38,7 @@ export const appScenes: Record<Scene, () => any> = {
     [Scene.EarlyAccessFeature]: () => import('./early-access-features/EarlyAccessFeature'),
     [Scene.Surveys]: () => import('./surveys/Surveys'),
     [Scene.Survey]: () => import('./surveys/Survey'),
-    [Scene.DataWarehouse]: () => import('./data-warehouse/posthog/DataWarehousePosthogScene'),
+    [Scene.DataWarehouse]: () => import('./data-warehouse/external/DataWarehouseExternalScene'),
     [Scene.DataWarehousePosthog]: () => import('./data-warehouse/posthog/DataWarehousePosthogScene'),
     [Scene.DataWarehouseExternal]: () => import('./data-warehouse/external/DataWarehouseExternalScene'),
     [Scene.DataWarehouseSavedQueries]: () => import('./data-warehouse/saved_queries/DataWarehouseSavedQueriesScene'),

diff --git a/frontend/src/scenes/data-warehouse/DataWarehousePageTabs.tsx b/frontend/src/scenes/data-warehouse/DataWarehousePageTabs.tsx
@@ -13,8 +13,8 @@ export enum DataWarehouseTab {
 }
 
 const tabUrls = {
-    [DataWarehouseTab.Posthog]: urls.dataWarehousePosthog(),
     [DataWarehouseTab.External]: urls.dataWarehouseExternal(),
+    [DataWarehouseTab.Posthog]: urls.dataWarehousePosthog(),
     [DataWarehouseTab.Views]: urls.dataWarehouseSavedQueries(),
 }
 
@@ -25,7 +25,7 @@ const dataWarehouseTabsLogic = kea<dataWarehouseTabsLogicType>({
     },
     reducers: {
         tab: [
-            DataWarehouseTab.Posthog as DataWarehouseTab,
+            DataWarehouseTab.External as DataWarehouseTab,
             {
                 setTab: (_, { tab }) => tab,
             },
@@ -58,14 +58,14 @@ export function DataWarehousePageTabs({ tab }: { tab: DataWarehouseTab }): JSX.E
                 activeKey={tab}
                 onChange={(t) => setTab(t)}
                 tabs={[
-                    {
-                        key: DataWarehouseTab.Posthog,
-                        label: <span data-attr="data-warehouse-Posthog-tab">Posthog</span>,
-                    },
                     {
                         key: DataWarehouseTab.External,
                         label: <span data-attr="data-warehouse-external-tab">External</span>,
                     },
+                    {
+                        key: DataWarehouseTab.Posthog,
+                        label: <span data-attr="data-warehouse-Posthog-tab">Posthog</span>,
+                    },
                     ...(featureFlags[FEATURE_FLAGS.DATA_WAREHOUSE_VIEWS]
                         ? [
                               {

diff --git a/frontend/src/scenes/data-warehouse/external/DataWarehouseExternalScene.tsx b/frontend/src/scenes/data-warehouse/external/DataWarehouseExternalScene.tsx
@@ -30,13 +30,15 @@ export function DataWarehouseExternalScene(): JSX.Element {
                     </div>
                 }
                 buttons={
-                    <LemonButton
-                        type="primary"
-                        to={urls.dataWarehouseTable('new')}
-                        data-attr="new-data-warehouse-table"
-                    >
-                        New Table
-                    </LemonButton>
+                    !shouldShowProductIntroduction ? (
+                        <LemonButton
+                            type="primary"
+                            to={urls.dataWarehouseTable('new')}
+                            data-attr="new-data-warehouse-table"
+                        >
+                            New Table
+                        </LemonButton>
+                    ) : undefined
                 }
                 caption={
                     <div>