fix: self hosted replay storage access (#24155)

PostHog · Aug 19, 2024 · d07960f · d07960f
1 parent bc8ad18
commit d07960f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/docker-compose.hobby.yml b/docker-compose.hobby.yml
@@ -71,6 +71,10 @@ services:
             SENTRY_DSN: $SENTRY_DSN
             SITE_URL: https://$DOMAIN
             SECRET_KEY: $POSTHOG_SECRET
+            OBJECT_STORAGE_ACCESS_KEY_ID: 'object_storage_root_user'
+            OBJECT_STORAGE_SECRET_ACCESS_KEY: 'object_storage_root_password'
+            OBJECT_STORAGE_ENDPOINT: http://objectstorage:19000
+            OBJECT_STORAGE_ENABLED: true
         image: $REGISTRY_URL:$POSTHOG_APP_TAG
     web:
         extends:
@@ -84,6 +88,8 @@ services:
             SENTRY_DSN: $SENTRY_DSN
             SITE_URL: https://$DOMAIN
             SECRET_KEY: $POSTHOG_SECRET
+            OBJECT_STORAGE_ACCESS_KEY_ID: 'object_storage_root_user'
+            OBJECT_STORAGE_SECRET_ACCESS_KEY: 'object_storage_root_password'
             OBJECT_STORAGE_ENDPOINT: http://objectstorage:19000
             OBJECT_STORAGE_ENABLED: true
         depends_on:
@@ -102,6 +108,10 @@ services:
             SENTRY_DSN: $SENTRY_DSN
             SITE_URL: https://$DOMAIN
             SECRET_KEY: $POSTHOG_SECRET
+            OBJECT_STORAGE_ACCESS_KEY_ID: 'object_storage_root_user'
+            OBJECT_STORAGE_SECRET_ACCESS_KEY: 'object_storage_root_password'
+            OBJECT_STORAGE_ENDPOINT: http://objectstorage:19000
+            OBJECT_STORAGE_ENABLED: true
         depends_on:
             - db
             - redis

diff --git a/plugin-server/src/main/services/object_storage.ts b/plugin-server/src/main/services/object_storage.ts
@@ -10,8 +10,6 @@ export interface ObjectStorage {
 
 let objectStorage: ObjectStorage | undefined
 
-// Object Storage added without any uses to flush out deployment concerns.
-// see https://github.com/PostHog/posthog/pull/9901
 export const getObjectStorage = (serverConfig: Partial<PluginsServerConfig>): ObjectStorage | undefined => {
     if (!objectStorage) {
         try {