fix(flags): don't use the cohort not_in operators for feature flags…

…, since we don't support that operation in flag matching yet (#25149)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

frontend/src/lib/components/DefinitionPopover/utils.ts

@@ -23,6 +23,10 @@ export function genericOperatorToHumanName(property?: AnyPropertyFilter | null):
 
 export function allOperatorsToHumanName(operator?: PropertyOperator | null): string {
     if (operator && allOperatorsMapping[operator]) {
+        // for the case of cohort matching, we want to return the operator name without the "In" prefix
+        if (operator === PropertyOperator.In) {
+            return 'in'
+        }
         return allOperatorsMapping[operator].slice(2)
     }
     return 'equals'

frontend/src/lib/components/PropertyFilters/PropertyFilters.tsx

@@ -38,6 +38,7 @@ interface PropertyFiltersProps {
     propertyAllowList?: { [key in TaxonomicFilterGroupType]?: string[] }
     allowRelativeDateOptions?: boolean
     disabledReason?: string
+    exactMatchFeatureFlagCohortOperators?: boolean
 }
 
 export function PropertyFilters({
@@ -65,6 +66,7 @@ export function PropertyFilters({
     propertyAllowList,
     allowRelativeDateOptions,
     disabledReason = undefined,
+    exactMatchFeatureFlagCohortOperators = false,
 }: PropertyFiltersProps): JSX.Element {
     const logicProps = { propertyFilters, onChange, pageKey, sendAllKeyUpdates }
     const { filters, filtersWithNew } = useValues(propertyFilterLogic(logicProps))
@@ -128,6 +130,7 @@ export function PropertyFilters({
                                             propertyAllowList={propertyAllowList}
                                             taxonomicFilterOptionsFromProp={taxonomicFilterOptionsFromProp}
                                             allowRelativeDateOptions={allowRelativeDateOptions}
+                                            exactMatchFeatureFlagCohortOperators={exactMatchFeatureFlagCohortOperators}
                                         />
                                     )}
                                     errorMessage={errorMessages && errorMessages[index]}

frontend/src/lib/components/PropertyFilters/components/TaxonomicPropertyFilter.tsx

@@ -48,6 +48,7 @@ export function TaxonomicPropertyFilter({
     propertyAllowList,
     taxonomicFilterOptionsFromProp,
     allowRelativeDateOptions,
+    exactMatchFeatureFlagCohortOperators,
 }: PropertyFilterInternalProps): JSX.Element {
     const pageKey = useMemo(() => pageKeyInput || `filter-${uniqueMemoizedIndex++}`, [pageKeyInput])
     const groupTypes = taxonomicGroupTypes || [
@@ -85,7 +86,14 @@ export function TaxonomicPropertyFilter({
     const showInitialSearchInline =
         !disablePopover &&
         ((!filter?.type && (!filter || !(filter as any)?.key)) || filter?.type === PropertyFilterType.HogQL)
-    const showOperatorValueSelect = filter?.type && filter?.key && filter?.type !== PropertyFilterType.HogQL
+    const showOperatorValueSelect =
+        filter?.type &&
+        filter?.key &&
+        !(filter?.type === PropertyFilterType.HogQL) &&
+        // If we're in a feature flag, we don't want to show operators for cohorts because
+        // we don't support any cohort matching operators other than "in"
+        // See https://github.com/PostHog/posthog/pull/25149/
+        !(filter?.type === PropertyFilterType.Cohort && exactMatchFeatureFlagCohortOperators)
     const placeOperatorValueSelectOnLeft = filter?.type && filter?.key && filter?.type === PropertyFilterType.Cohort
 
     const { propertyDefinitionsByType } = useValues(propertyDefinitionsModel)

frontend/src/lib/components/PropertyFilters/types.ts

@@ -50,4 +50,5 @@ export interface PropertyFilterInternalProps {
     metadataSource?: AnyDataNode
     propertyAllowList?: { [key in TaxonomicFilterGroupType]?: string[] }
     allowRelativeDateOptions?: boolean
+    exactMatchFeatureFlagCohortOperators?: boolean
 }

frontend/src/scenes/feature-flags/FeatureFlagReleaseConditions.tsx

@@ -244,6 +244,7 @@ export function FeatureFlagReleaseConditions({
                                           })
                                         : null
                                 }
+                                exactMatchFeatureFlagCohortOperators={true}
                             />
                         </div>
                     )}