fix: Loop requests in toolbar (#21061)

PostHog · Mar 21, 2024 · cca6ccb · cca6ccb
1 parent da97985
commit cca6ccb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/frontend/src/toolbar/actions/ActionsListView.tsx b/frontend/src/toolbar/actions/ActionsListView.tsx
@@ -1,7 +1,6 @@
 import { Link } from '@posthog/lemon-ui'
 import { useActions, useValues } from 'kea'
 import { Spinner } from 'lib/lemon-ui/Spinner'
-import { useEffect } from 'react'
 
 import { actionsLogic } from '~/toolbar/actions/actionsLogic'
 import { actionsTabLogic } from '~/toolbar/actions/actionsTabLogic'
@@ -13,13 +12,8 @@ interface ActionsListViewProps {
 
 export function ActionsListView({ actions }: ActionsListViewProps): JSX.Element {
     const { allActionsLoading, searchTerm } = useValues(actionsLogic)
-    const { getActions } = useActions(actionsLogic)
     const { selectAction } = useActions(actionsTabLogic)
 
-    useEffect(() => {
-        getActions()
-    }, [])
-
     return (
         <div className="flex flex-col h-full overflow-y-scoll space-y-px">
             {actions.length ? (

diff --git a/frontend/src/toolbar/actions/ActionsToolbarMenu.tsx b/frontend/src/toolbar/actions/ActionsToolbarMenu.tsx
@@ -5,6 +5,7 @@ import { LemonButton } from 'lib/lemon-ui/LemonButton'
 import { LemonInput } from 'lib/lemon-ui/LemonInput'
 import { Link } from 'lib/lemon-ui/Link'
 import { Spinner } from 'lib/lemon-ui/Spinner'
+import { useEffect } from 'react'
 import { urls } from 'scenes/urls'
 
 import { ActionsEditingToolbarMenu } from '~/toolbar/actions/ActionsEditingToolbarMenu'
@@ -16,13 +17,17 @@ import { toolbarConfigLogic } from '~/toolbar/toolbarConfigLogic'
 
 const ActionsListToolbarMenu = (): JSX.Element => {
     const { searchTerm } = useValues(actionsLogic)
-    const { setSearchTerm } = useActions(actionsLogic)
+    const { setSearchTerm, getActions } = useActions(actionsLogic)
 
     const { newAction } = useActions(actionsTabLogic)
     const { allActions, sortedActions, allActionsLoading } = useValues(actionsLogic)
 
     const { apiURL } = useValues(toolbarConfigLogic)
 
+    useEffect(() => {
+        getActions()
+    }, [])
+
     return (
         <ToolbarMenu>
             <ToolbarMenu.Header>