Skip to content

Commit

Permalink
chore: remove muted alt button (#18388)
Browse files Browse the repository at this point in the history
  • Loading branch information
daibhin authored Nov 6, 2023
1 parent 4c3f87d commit ca01fa1
Show file tree
Hide file tree
Showing 16 changed files with 11 additions and 8 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-lemon-button--loading.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-lemon-button--no-padding.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-lemon-button--sizes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-lemon-button--text-only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const ProductIntroduction = ({
{docsURL && (
<LemonButton
type={actionable ? 'tertiary' : 'secondary'}
status="muted-alt"
status="muted"
sideIcon={<IconOpenInNew className="w-4 h-4" />}
to={`${docsURL}?utm_medium=in-product&utm_campaign=empty-state-docs-link`}
data-attr="product-introduction-docs-link"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/lemon-ui/LemonButton/LemonButton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
}
}

@each $status in ('default', 'primary', 'danger', 'primary-alt', 'muted', 'muted-alt') {
@each $status in ('primary', 'danger', 'primary-alt', 'muted') {
&.LemonButton--status-#{$status} {
color: var(--#{$status}, var(--primary));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { useAsyncHandler } from 'lib/hooks/useAsyncHandler'
import clsx from 'clsx'
import { LemonBanner } from 'lib/lemon-ui/LemonBanner'

const statuses: LemonButtonProps['status'][] = ['primary', 'danger', 'primary-alt', 'muted']
const statuses: LemonButtonProps['status'][] = ['primary', 'danger', 'primary-alt', 'muted', 'stealth']
const types: LemonButtonProps['type'][] = ['primary', 'secondary', 'tertiary']

type Story = StoryObj<typeof LemonButton>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/lemon-ui/LemonButton/LemonButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface LemonButtonPropsBase
children?: React.ReactNode
type?: 'primary' | 'secondary' | 'tertiary'
/** Button color scheme. */
status?: 'primary' | 'danger' | 'primary-alt' | 'muted' | 'muted-alt' | 'stealth'
status?: 'primary' | 'danger' | 'primary-alt' | 'muted' | 'stealth'
/** Whether hover style should be applied, signaling that the button is held active in some way. */
active?: boolean
/** URL to link to. */
Expand Down
9 changes: 6 additions & 3 deletions frontend/src/queries/QueryEditor/QueryEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ export function QueryEditor(props: QueryEditorProps): JSX.Element {
) : null}
<div
data-attr="query-editor"
className={clsx('flex flex-col p-2 bg-border space-y-2 resize-y overflow-auto h-80', props.className)}
className={clsx(
'flex flex-col p-2 bg-mid space-y-2 resize-y overflow-auto h-80 rounded-sm',
props.className
)}
>
<div className="flex-1">
<AutoSizer disableWidth>
Expand All @@ -72,13 +75,13 @@ export function QueryEditor(props: QueryEditorProps): JSX.Element {
<LemonButton
onClick={saveQuery}
type="primary"
status={error ? 'danger' : 'muted-alt'}
status={error ? 'danger' : 'primary'}
disabled={!props.setQuery || !!error || !inputChanged}
fullWidth
center
data-attr="query-editor-save"
>
{!props.setQuery ? 'No permission to update' : 'Update'}
{!props.setQuery ? 'No permission to update' : 'Update and run'}
</LemonButton>
</div>
</>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/onboarding/sdks/SDKs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function SDKs({
{sdks?.map((sdk) => (
<React.Fragment key={`sdk-${sdk.key}`}>
<LemonButton
status={selectedSDK?.key === sdk.key ? 'primary' : 'muted-alt'}
status={selectedSDK?.key === sdk.key ? 'primary' : 'muted'}
active={selectedSDK?.key === sdk.key}
onClick={selectedSDK?.key !== sdk.key ? () => setSelectedSDK(sdk) : undefined}
fullWidth
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit ca01fa1

Please sign in to comment.