fix: New notebook from popover (#17494)

PostHog · Sep 18, 2023 · c9c4d9a · c9c4d9a
1 parent 45c82dc
commit c9c4d9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...napshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png b/...napshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png
diff --git a/frontend/src/scenes/notebooks/NotebookSelectButton/NotebookSelectButton.tsx b/frontend/src/scenes/notebooks/NotebookSelectButton/NotebookSelectButton.tsx
@@ -81,12 +81,10 @@ export function NotebookSelectList(props: NotebookSelectProps): JSX.Element {
     const openNewNotebook = (): void => {
         const title = newNotebookTitle ?? `Notes ${dayjs().format('DD/MM')}`
 
-        if (resource) {
-            createNotebook(title, NotebookTarget.Popover, [resource], (theNotebookLogic) => {
-                props.onNotebookOpened?.(theNotebookLogic)
-                loadNotebooksContainingResource()
-            })
-        }
+        createNotebook(title, NotebookTarget.Popover, resource ? [resource] : undefined, (theNotebookLogic) => {
+            props.onNotebookOpened?.(theNotebookLogic)
+            loadNotebooksContainingResource()
+        })
 
         setShowPopover(false)
     }