Skip to content

Commit

Permalink
fix a flaking test
Browse files Browse the repository at this point in the history
  • Loading branch information
nikitaevg committed Jun 16, 2024
1 parent 20ff6ca commit c85d199
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion ee/api/test/test_dashboard_collaborators.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@ def test_list_collaborators_as_person_without_edit_access(self):
response = self.client.get(
f"/api/projects/{self.test_dashboard.team_id}/dashboards/{self.test_dashboard.id}/collaborators/"
)
self.assertEqual(response.status_code, status.HTTP_200_OK)

response_data = response.json()
response_data = sorted(response_data, key=lambda entry: entry["user"]["email"])

self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(len(response_data), 2)
self.assertEqual(response_data[0]["user"]["email"], other_user_a.email)
self.assertEqual(response_data[0]["level"], Dashboard.PrivilegeLevel.CAN_VIEW)
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/scenes/insights/views/LineGraph/LineGraph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -652,9 +652,9 @@ export function LineGraph_({
display: !hideYAxis,
...tickOptions,
...(yAxisScaleType !== 'log10' && { precision }), // Precision is not supported for the log scale
callback: (value) => {
return formatPercentStackAxisValue(trendsFilter, value, isPercentStackView)
},
// callback: (value) => {
// return formatPercentStackAxisValue(trendsFilter, value, isPercentStackView)
// },
},
grid: gridOptions,
type: yAxisScaleType === 'log10' ? 'logarithmic' : 'linear',
Expand Down

0 comments on commit c85d199

Please sign in to comment.