fix(surveys): multiple questions bug fix (#17832)

* fix multiple questions new q * remove debugger
PostHog · Oct 5, 2023 · c5e4a99 · c5e4a99
1 parent 8e754e4
commit c5e4a99
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/frontend/src/scenes/surveys/Survey.tsx b/frontend/src/scenes/surveys/Survey.tsx
@@ -332,7 +332,10 @@ export function SurveyForm({ id }: { id: string }): JSX.Element {
                             className="w-max"
                             icon={<IconPlus />}
                             onClick={() => {
-                                setSurveyValue('questions', [...survey.questions, { ...defaultSurveyFieldValues.open }])
+                                setSurveyValue('questions', [
+                                    ...survey.questions,
+                                    { ...defaultSurveyFieldValues.open.questions[0] },
+                                ])
                             }}
                         >
                             Add question

diff --git a/frontend/src/scenes/surveys/constants.ts b/frontend/src/scenes/surveys/constants.ts
@@ -35,6 +35,7 @@ export const defaultSurveyFieldValues = {
     [SurveyQuestionType.Open]: {
         questions: [
             {
+                type: SurveyQuestionType.Open,
                 question: 'Give us feedback on our product!',
                 description: '',
             },
@@ -47,6 +48,7 @@ export const defaultSurveyFieldValues = {
     [SurveyQuestionType.Link]: {
         questions: [
             {
+                type: SurveyQuestionType.Link,
                 question: 'Do you want to join our upcoming webinar?',
                 description: '',
             },
@@ -59,6 +61,7 @@ export const defaultSurveyFieldValues = {
     [SurveyQuestionType.Rating]: {
         questions: [
             {
+                type: SurveyQuestionType.Rating,
                 question: 'How likely are you to recommend us to a friend?',
                 description: '',
                 display: 'number',
@@ -74,6 +77,7 @@ export const defaultSurveyFieldValues = {
     [SurveyQuestionType.SingleChoice]: {
         questions: [
             {
+                type: SurveyQuestionType.SingleChoice,
                 question: 'Have you found this tutorial useful?',
                 description: '',
                 choices: ['Yes', 'No'],
@@ -87,6 +91,7 @@ export const defaultSurveyFieldValues = {
     [SurveyQuestionType.MultipleChoice]: {
         questions: [
             {
+                type: SurveyQuestionType.MultipleChoice,
                 question: 'Which types of content would you like to see more of?',
                 description: '',
                 choices: ['Tutorials', 'Customer case studies', 'Product announcements'],

diff --git a/frontend/src/scenes/surveys/surveyLogic.tsx b/frontend/src/scenes/surveys/surveyLogic.tsx
@@ -167,17 +167,17 @@ export const surveyLogic = kea<surveyLogicType>([
                 ) => {
                     const question = isEditingQuestion
                         ? state.questions[idx].question
-                        : defaultSurveyFieldValues[type].questions[idx].question
+                        : defaultSurveyFieldValues[type].questions[0].question
                     const description = isEditingDescription
                         ? state.questions[idx].description
-                        : defaultSurveyFieldValues[type].questions[idx].description
+                        : defaultSurveyFieldValues[type].questions[0].description
                     const thankYouMessageHeader = isEditingThankYouMessage
                         ? state.appearance.thankYouMessageHeader
                         : defaultSurveyFieldValues[type].appearance.thankYouMessageHeader
                     const newQuestions = [...state.questions]
                     newQuestions[idx] = {
                         ...state.questions[idx],
-                        ...(defaultSurveyFieldValues[type].questions[idx] as SurveyQuestionBase),
+                        ...(defaultSurveyFieldValues[type].questions[0] as SurveyQuestionBase),
                         question,
                         description,
                     }