Skip to content

Commit

Permalink
fix: test for ast.Constant(value=None) (#26481)
Browse files Browse the repository at this point in the history
  • Loading branch information
fuziontech authored Nov 27, 2024
1 parent 48107f6 commit c4d23ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion posthog/hogql_queries/web_analytics/web_overview.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def event_type_expr(self) -> ast.Expr:
op=ast.CompareOperationOp.Eq, left=ast.Field(chain=["event"]), right=ast.Constant(value="$pageview")
)

if self.conversion_goal_expr:
if self.conversion_goal_expr and self.conversion_goal_expr != ast.Constant(value=None):
return ast.Call(name="or", args=[pageview_expr, self.conversion_goal_expr])
else:
return pageview_expr
Expand Down

0 comments on commit c4d23ac

Please sign in to comment.