Skip to content

Commit

Permalink
fix: comparing object instance equality is bad m'kay (#26751)
Browse files Browse the repository at this point in the history
  • Loading branch information
pauldambra authored Dec 9, 2024
1 parent df20817 commit c46a495
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { subscriptions } from 'kea-subscriptions'
import { delay } from 'kea-test-utils'
import { now } from 'lib/dayjs'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { clamp, downloadFile } from 'lib/utils'
import { clamp, downloadFile, objectsEqual } from 'lib/utils'
import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import { wrapConsole } from 'lib/utils/wrapConsole'
import posthog from 'posthog-js'
Expand Down Expand Up @@ -860,7 +860,7 @@ export const sessionRecordingPlayerLogic = kea<sessionRecordingPlayerLogicType>(
// Check if we're seeking to a new segment
const segment = values.segmentForTimestamp(timestamp)

if (segment && segment !== values.currentSegment) {
if (segment && !objectsEqual(segment, values.currentSegment)) {
actions.setCurrentSegment(segment)
}

Expand Down

0 comments on commit c46a495

Please sign in to comment.