fix(experiments): Restore editing Trends exposure metric (#27241)

PostHog · Jan 3, 2025 · c40b194 · c40b194
1 parent 12eb711
commit c40b194
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/frontend/src/scenes/experiments/ExperimentView/Goal.tsx b/frontend/src/scenes/experiments/ExperimentView/Goal.tsx
@@ -114,7 +114,9 @@ export function MetricDisplayOld({ filters }: { filters?: FilterType }): JSX.Ele
 
 export function ExposureMetric({ experimentId }: { experimentId: Experiment['id'] }): JSX.Element {
     const { experiment, featureFlags } = useValues(experimentLogic({ experimentId }))
-    const { updateExperimentGoal, loadExperiment, setExperiment } = useActions(experimentLogic({ experimentId }))
+    const { updateExperimentGoal, loadExperiment, setExperiment, setEditingPrimaryMetricIndex } = useActions(
+        experimentLogic({ experimentId })
+    )
     const [isModalOpen, setIsModalOpen] = useState(false)
 
     const metricIdx = 0
@@ -201,6 +203,7 @@ export function ExposureMetric({ experimentId }: { experimentId: Experiment['id'
                                     })
                                 }
                             }
+                            setEditingPrimaryMetricIndex(metricIdx)
                             setIsModalOpen(true)
                         }}
                         className="mr-2"
@@ -232,6 +235,7 @@ export function ExposureMetric({ experimentId }: { experimentId: Experiment['id'
                 isOpen={isModalOpen}
                 onClose={() => {
                     setIsModalOpen(false)
+                    setEditingPrimaryMetricIndex(null)
                     loadExperiment()
                 }}
             />

diff --git a/frontend/src/scenes/experiments/experimentLogic.tsx b/frontend/src/scenes/experiments/experimentLogic.tsx
@@ -275,6 +275,7 @@ export const experimentLogic = kea<experimentLogicType>([
         openPrimaryMetricModal: (index: number) => ({ index }),
         closePrimaryMetricModal: true,
         setPrimaryMetricsResultErrors: (errors: any[]) => ({ errors }),
+        setEditingPrimaryMetricIndex: (index: number | null) => ({ index }),
         updateDistributionModal: (featureFlag: FeatureFlagType) => ({ featureFlag }),
         openSecondaryMetricModal: (index: number) => ({ index }),
         closeSecondaryMetricModal: true,
@@ -511,6 +512,7 @@ export const experimentLogic = kea<experimentLogicType>([
                 openPrimaryMetricModal: (_, { index }) => index,
                 closePrimaryMetricModal: () => null,
                 updateExperimentGoal: () => null,
+                setEditingPrimaryMetricIndex: (_, { index }) => index,
             },
         ],
         primaryMetricsResultErrors: [