fix(hogql): fix schema for empty time-to-convert results (#20944)

PostHog · Mar 15, 2024 · c340790 · c340790
1 parent 800fddb
commit c340790
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/frontend/src/queries/schema.json b/frontend/src/queries/schema.json
@@ -1960,7 +1960,7 @@
             "additionalProperties": false,
             "properties": {
                 "average_conversion_time": {
-                    "type": "number"
+                    "type": ["number", "null"]
                 },
                 "bins": {
                     "items": {

diff --git a/frontend/src/queries/schema.ts b/frontend/src/queries/schema.ts
@@ -713,7 +713,7 @@ type BinNumber = number
 export type FunnelStepsResults = Record<string, any>[]
 export type FunnelStepsBreakdownResults = Record<string, any>[][]
 export type FunnelTimeToConvertResults = {
-    average_conversion_time: number
+    average_conversion_time: number | null
     bins: [BinNumber, BinNumber][]
 }
 export type FunnelTrendsResults = Record<string, any>[]

diff --git a/posthog/schema.py b/posthog/schema.py
@@ -355,7 +355,7 @@ class FunnelTimeToConvertResults(BaseModel):
     model_config = ConfigDict(
         extra="forbid",
     )
-    average_conversion_time: float
+    average_conversion_time: Optional[float] = None
     bins: List[List[int]]