Fix mobile experience

PostHog · Jan 30, 2024 · c1d1317 · c1d1317
1 parent ba74d97
commit c1d1317
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/frontend/src/layout/navigation-3000/navigationLogic.tsx b/frontend/src/layout/navigation-3000/navigationLogic.tsx
@@ -59,6 +59,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
     props({} as { inputElement?: HTMLInputElement | null }),
     connect(() => ({
         values: [sceneLogic, ['sceneConfig'], navigationLogic, ['mobileLayout'], teamLogic, ['currentTeam']],
+        actions: [navigationLogic, ['closeAccountPopover']],
     })),
     actions({
         hideSidebar: true,
@@ -133,6 +134,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
             {
                 showNavOnMobile: () => true,
                 hideNavOnMobile: () => false,
+                closeAccountPopover: () => false,
             },
         ],
         isSidebarKeyboardShortcutAcknowledged: [

diff --git a/frontend/src/layout/navigation/TopBar/AccountPopover.tsx b/frontend/src/layout/navigation/TopBar/AccountPopover.tsx
@@ -184,6 +184,7 @@ export function AccountPopoverOverlay(): JSX.Element {
     const { user, otherOrganizations } = useValues(userLogic)
     const { currentOrganization } = useValues(organizationLogic)
     const { preflight } = useValues(preflightLogic)
+    const { mobileLayout } = useValues(navigationLogic)
     const { closeAccountPopover } = useActions(navigationLogic)
     const { billing } = useValues(billingLogic)
     const { openSidePanel } = useActions(sidePanelStateLogic)
@@ -225,9 +226,11 @@ export function AccountPopoverOverlay(): JSX.Element {
                 <LemonButton
                     to="https://posthog.com/changelog"
                     onClick={(e) => {
-                        e.preventDefault()
                         closeAccountPopover()
-                        openSidePanel(SidePanelTab.Docs, '/changelog')
+                        if (!mobileLayout) {
+                            e.preventDefault()
+                            openSidePanel(SidePanelTab.Docs, '/changelog')
+                        }
                     }}
                     icon={<IconLive />}
                     fullWidth