Abstract property chain into a cached prop

PostHog · Oct 12, 2023 · c0211d9 · c0211d9
1 parent 16febec
commit c0211d9
Showing 1 changed file with 12 additions and 28 deletions.
diff --git a/posthog/hogql_queries/insights/trends/breakdown.py b/posthog/hogql_queries/insights/trends/breakdown.py
@@ -41,24 +41,12 @@ def column_expr(self) -> ast.Expr:
 
         return ast.Alias(
             alias="breakdown_value",
-            expr=ast.Field(
-                chain=get_properties_chain(
-                    breakdown_type=self.query.breakdown.breakdown_type,
-                    breakdown_field=self.query.breakdown.breakdown,
-                    group_type_index=self.query.breakdown.breakdown_group_type_index,
-                )
-            ),
+            expr=ast.Field(chain=self._properties_chain),
         )
 
     def events_where_filter(self) -> ast.Expr:
         return ast.CompareOperation(
-            left=ast.Field(
-                chain=get_properties_chain(
-                    breakdown_type=self.query.breakdown.breakdown_type,
-                    breakdown_field=self.query.breakdown.breakdown,
-                    group_type_index=self.query.breakdown.breakdown_group_type_index,
-                )
-            ),
+            left=ast.Field(chain=self._properties_chain),
             op=ast.CompareOperationOp.In,
             right=self._breakdown_values_ast,
         )
@@ -118,24 +106,12 @@ def _get_breakdown_histogram_multi_if(self) -> ast.Expr:
                     ast.And(
                         exprs=[
                             ast.CompareOperation(
-                                left=ast.Field(
-                                    chain=get_properties_chain(
-                                        breakdown_type=self.query.breakdown.breakdown_type,
-                                        breakdown_field=self.query.breakdown.breakdown,
-                                        group_type_index=self.query.breakdown.breakdown_group_type_index,
-                                    )
-                                ),
+                                left=ast.Field(chain=self._properties_chain),
                                 op=ast.CompareOperationOp.GtEq,
                                 right=ast.Constant(value=lower_bound),
                             ),
                             ast.CompareOperation(
-                                left=ast.Field(
-                                    chain=get_properties_chain(
-                                        breakdown_type=self.query.breakdown.breakdown_type,
-                                        breakdown_field=self.query.breakdown.breakdown,
-                                        group_type_index=self.query.breakdown.breakdown_group_type_index,
-                                    )
-                                ),
+                                left=ast.Field(chain=self._properties_chain),
                                 op=ast.CompareOperationOp.Lt,
                                 right=ast.Constant(value=upper_bound),
                             ),
@@ -149,3 +125,11 @@ def _get_breakdown_histogram_multi_if(self) -> ast.Expr:
         multi_if_exprs.append(ast.Constant(value='["",""]'))
 
         return ast.Call(name="multiIf", args=multi_if_exprs)
+
+    @cached_property
+    def _properties_chain(self):
+        return get_properties_chain(
+            breakdown_type=self.query.breakdown.breakdown_type,
+            breakdown_field=self.query.breakdown.breakdown,
+            group_type_index=self.query.breakdown.breakdown_group_type_index,
+        )