Skip to content

Commit

Permalink
Fix typing more
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes committed Apr 17, 2024
1 parent 65147a0 commit bb87101
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion posthog/api/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def create(self, request, *args, **kwargs) -> Response:
user_id=self.request.user.pk,
query_json=request.data["query"],
query_id=client_query_id,
refresh_requested=data.refresh,
refresh_requested=data.refresh or False,
)
return Response(query_status.model_dump(), status=status.HTTP_202_ACCEPTED)

Expand Down
5 changes: 3 additions & 2 deletions posthog/hogql_queries/test/test_events_query_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ def _run_boolean_field_query(self, filter: EventPropertyFilter):
)

runner = EventsQueryRunner(query=query, team=self.team)
results = runner.run().results
assert isinstance(results, QueryResponse)
response = runner.run()
assert isinstance(response, QueryResponse)

Check failure on line 89 in posthog/hogql_queries/test/test_events_query_runner.py

View workflow job for this annotation

GitHub Actions / Python code quality checks

Subclass of "CachedQueryResponse" and "QueryResponse" cannot exist: would have incompatible method signatures

Check failure on line 89 in posthog/hogql_queries/test/test_events_query_runner.py

View workflow job for this annotation

GitHub Actions / Python code quality checks

Subclass of "CacheMissResponse" and "QueryResponse" cannot exist: would have incompatible method signatures
results = response.results

Check failure on line 90 in posthog/hogql_queries/test/test_events_query_runner.py

View workflow job for this annotation

GitHub Actions / Python code quality checks

Statement is unreachable
return results

def test_is_not_set_boolean(self):
Expand Down

0 comments on commit bb87101

Please sign in to comment.